Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Fix unpack data for signing transaction #399

Closed
linh2931 opened this issue Jun 15, 2022 · 1 comment · Fixed by #581
Closed

Backport: Fix unpack data for signing transaction #399

linh2931 opened this issue Jun 15, 2022 · 1 comment · Fixed by #581
Assignees
@oschwaldp-oci @ClaytonCalabrese
Labels
3.2 Candidate OCI OCI working this issue...
Milestone
Mandel 3.2.0

Comments

@linh2931
Copy link
Member

EOSIO/eos#8931

A failure to sign transactions was reported by EOSIO/eos#8911 on develop on April 20, 2020 (eosio v 2.0.4 worked). Need to verify if the bug exists on mandel. Port the fix if it does.
@ClaytonCalabrese ClaytonCalabrese self-assigned this Jun 22, 2022
@ClaytonCalabrese
Copy link
Contributor

This bug does not appear to happen on mandel.

@linh2931 linh2931 mentioned this issue Jun 28, 2022
Closed
@oschwaldp-oci oschwaldp-oci self-assigned this Jun 30, 2022
oschwaldp-oci pushed a commit that referenced this issue Jun 30, 2022
@allenhan2 @oschwaldp-oci
GH-399 Merge pull request #8931 from EOSIO/fix_sign_unpack_data
2fde691 
Fix unpack data for signing transaction
oschwaldp-oci added a commit that referenced this issue Jun 30, 2022
@oschwaldp-oci
GH-399 Fix up argument list to make sure all arguments align.
f184f2b
@oschwaldp-oci oschwaldp-oci mentioned this issue Jun 30, 2022
Merged
@oschwaldp-oci oschwaldp-oci added 3.2 Candidate OCI OCI working this issue... labels Jun 30, 2022
@arhag arhag added this to the Mandel 3.2.0-rc1 milestone Jul 1, 2022
@stephenpdeos stephenpdeos modified the milestones: Mandel 3.2.0-rc1, Mandel 3.2.0 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oschwaldp-oci oschwaldp-oci

@ClaytonCalabrese ClaytonCalabrese

Labels
3.2 Candidate OCI OCI working this issue...
Projects
None yet
Milestone
Mandel 3.2.0
Development

Successfully merging a pull request may close this issue.

[3.2] Backport: Fix unpack data for signing transaction eosnetworkfoundation/mandel
5 participants
@arhag @oschwaldp-oci @ClaytonCalabrese @stephenpdeos @linh2931