[3.2] abieos: Fix compile warning -- throw will always call terminate() #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #5
abieos.cpp
produces 120 occurrences of the following warnings:The offending code is
while
catch_all
is defined asinline const bool catch_all = true;
The solution is, make
catch_all
constexpr, check if a preprocessorABIEOS_NOT_CATCH_ALL
is defined and setcatch_all
true or false accordingly; and doif constexpr
.After the changes, no more warnings are generated from
aieos.cpp
.