Fix shadow mode metric is not collected when local cache hit #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seonghyun Oh <seonghyunoh@gmail.com>
fc22497 to
f9c6402
Compare
upgle
commented
May 18, 2023
| assert.Equal(uint64(1), limits[0].Stats.NearLimit.Value()) | ||
| assert.Equal(uint64(3), limits[0].Stats.WithinLimit.Value()) | ||
| assert.Equal(uint64(2), limits[0].Stats.WithinLimit.Value()) |
There was a problem hiding this comment.
This value should be 2. Please refer to the original test code for local cache.
(Even if shadow mode is enabled, this value should not be changed.)
ratelimit/test/redis/fixed_cache_impl_test.go
Lines 276 to 280 in b3562ca
upgle
commented
May 18, 2023
| } | ||
|
|
||
| isOverLimitWithLocalCache[i] = true |
There was a problem hiding this comment.
- Shadow mode and local cache should be irrelevant.
- If the local cache is hit, the continue statement does not perform the INCR command, but the GetResponseDescriptorStatus method does not handle it properly.
upgle
commented
May 18, 2023
| @@ -80,9 +80,9 @@ func (this *BaseRateLimiter) GetResponseDescriptorStatus(key string, limitInfo * | |||
| nil, 0) | |||
| } | |||
| var responseDescriptorStatus *pb.RateLimitResponse_DescriptorStatus | |||
| over_limit := false | |||
There was a problem hiding this comment.
This does not follow the Golang naming convention.
|
Can you check CI? Not sure if it's a flake or not. |
|
@mattklein123 |
mattklein123
approved these changes
May 30, 2023
barroca
pushed a commit
to barroca/ratelimit
that referenced
this pull request
Sep 1, 2023
Signed-off-by: Seonghyun Oh <seonghyunoh@gmail.com>
timcovar
pushed a commit
to goatapp/ratelimit
that referenced
this pull request
Jan 16, 2024
Signed-off-by: Seonghyun Oh <seonghyunoh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #423 issue where statistics were not collected correctly when hitting the local cache.
If the local cache is hit, the rate limit service does not perform the INCR command, but the GetResponseDescriptorStatus method does not handle it properly.
Invalid metric
shadow mode stats are not collected for the actual number of requests.
Expected
shadow mode stat should be the same value as over limit .