Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use replace in examples and xdsmatcher #849

Closed
wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 changed the title use replace in ewamples and xdsmatcher use replace in examples and xdsmatcher Jan 5, 2024
@phlax
Copy link
Member

phlax commented Jan 5, 2024

can you give some explanation of change (apologies if its obvious)

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Jan 5, 2024

go.mod requires pined versions.
When there are multiples modules on a repository that are interdependant, the use of replace allows to use the up to date version of the local modules in the go.mod file.

There might be another option which is to use go.work files but it’s not recommanded to persist it in the repository so I not very keen to use it.

@phlax
Copy link
Member

phlax commented Jan 5, 2024

thnks for explanation - i have seen it used in Envoy and wasnt 100% clear about what it did

Copy link

github-actions bot commented Feb 4, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 4, 2024
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Feb 11, 2024
@mmorel-35
Copy link
Contributor Author

Hi @phlax ,

Why was it not merged ?
Shall I reopen this ?

@phlax
Copy link
Member

phlax commented Apr 1, 2024

Why was it not merged ?

fell through the cracks i think

Shall I reopen this ?

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants