Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Remove Go minor version from go.mods #1078

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

mmorel-35
Copy link
Contributor

Closes #1077

@mmorel-35
Copy link
Contributor Author

@valerian-roche ,
With this and a new version for each module, grpc-go could be using the new modules. WDYT ?

@mmorel-35 mmorel-35 enabled auto-merge (squash) January 2, 2025 21:08
@mmorel-35 mmorel-35 force-pushed the remove-patch-version branch from 814af20 to b7b9f43 Compare January 2, 2025 21:15
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the remove-patch-version branch from b7b9f43 to a813090 Compare January 2, 2025 21:23
@valerian-roche
Copy link
Contributor

@valerian-roche , With this and a new version for each module, grpc-go could be using the new modules. WDYT ?

I think we'd still need #1075 on top, but this would be the first piece. The main question is: should we go back to 21? This way the new version would not increase the go version compared to the previous release, and once the versioning issue has been solved we can take a look at updating again?

@mmorel-35 mmorel-35 merged commit 2ea9c8b into envoyproxy:main Jan 2, 2025
5 checks passed
@mmorel-35 mmorel-35 deleted the remove-patch-version branch January 2, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying Go minor version in go.mod forces users to upgrade their Go minor versions as well
2 participants