adaptive concurrency: Fix min_concurrency behavior when gradient shrinks #9947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The min_concurrency setting dicated the concurrency limit when in a min_rtt calculation window. However, if the gradient caused the concurrency limit to shrink, it was possible for the limit to drop below this configured minimum. This patch fixes this behavior so that the calculated concurrency limit is always >= the configured minimum. In addition, a minor change to the stat indicating whether the min_rtt calculation window is active. When active, the stat was being set to the concurrency limit; however, according to the documentation this should be either 0 or 1. This patch also fixes this behavior. Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
|
LGTM thanks. Can you merge master? /wait |
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The min_concurrency setting dictated the concurrency limit when in a
min_rtt calculation window. However, if the gradient caused the
concurrency limit to shrink (due to increased latency), it was possible
for the limit to drop below this configured minimum. This patch fixes
this behavior so that the calculated concurrency limit is always >= the
configured minimum.
In addition, a minor change to the stat indicating whether the min_rtt
calculation window is active. When active, the stat was being set to the
concurrency limit; however, according to the documentation this should
be either 0 or 1. This patch also fixes this behavior.
Risk Level: Low, this filter is still experimental.
Testing: Adaptive concurrency tests