Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 1.3.0 release notes #926

Merged
merged 7 commits into from
May 17, 2017
Merged

docs: 1.3.0 release notes #926

merged 7 commits into from
May 17, 2017

Conversation

mattklein123
Copy link
Member

No description provided.

@mattklein123
Copy link
Member Author

@lyft/network-team and everyone else. Please have a look. There may be a few straggling things that we get in here but this is pretty close.

configuration.
* TCP level :ref:`listener <config_listeners_per_connection_buffer_limit_bytes>` and
:ref:`cluster <config_cluster_manager_cluster_per_connection_buffer_limit_bytes>` connections now
have configurable buffer limits at which point connection level back pressure is applied. Full end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We technically don't have back pressure yet, we're only using them on the receive side to ensure we start pushing the buffers down the filter chain when we hit the limits.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update.

Copy link
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to call out breaking changes in config.

a route's retry policy in addition to via the :ref:`x-envoy-upstream-rq-per-try-timeout-ms
<config_http_filters_router_x-envoy-upstream-rq-per-try-timeout-ms>` HTTP header.
* :ref:`HTTP virtual host matching <config_http_conn_man_route_table_vhost>` now includes support
for wildcard domains.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just prefix wildcard or suffix. Not arbitrary wildcard is it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup will fix.

* The :ref:`HTTP rate limit filter <config_http_filters_rate_limit>` can now be applied to internal,
external, or all requests via the `request_type` option.
* :ref:`Listener binding <config_listeners>` now requires specifying an `address` field. This can be
used to bind a listener to both a specific address as well as a port.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit needs to move to top and probably be called out as a breaking change in the config.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The breaking change policy starts at 1.3.0, so I'm not going to list out every breaking change. I will clarify the text a bit to make this clear.

@rshriram
Copy link
Member

rshriram commented May 9, 2017

And do you expect the zipkin stuff to get in by 1.3 time frame ?

@mattklein123
Copy link
Member Author

And do you expect the zipkin stuff to get in by 1.3 time frame ?

I will take a look at the PR tomorrow and try to get a feel for how close it is. Releases are obviously totally arbitrary and most people are running master, so making it by a particular release is not super important IMO.

ccaraman
ccaraman previously approved these changes May 9, 2017
Copy link
Contributor

@ccaraman ccaraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

<config_listener_ssl_context>` setting. Additionally, URI type SANs can be verified.
* HTTP filters can now be passed :ref:`opaque configuration
<config_http_conn_man_route_table_opaque_config>` specified on a per route basis.
* By default Envoy now has a built in crash handler that will print a back trace. This behavior can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add zipkin tracing support?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes will refresh this PR today.

@mattklein123
Copy link
Member Author

@rshriram @htuch @lyft/network-team updated, PTAL.

Copy link
Member

@RomanDzhabarov RomanDzhabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@mattklein123 mattklein123 merged commit 3afc771 into master May 17, 2017
@mattklein123 mattklein123 deleted the release_notes branch May 17, 2017 18:37
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants