Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix CentOS build image #7414

Closed
wants to merge 1 commit into from

Conversation

taiki45
Copy link
Member

@taiki45 taiki45 commented Jun 27, 2019

Description:
Current CentOS build image is broken since bazel 0.27.0 released due to its unintentional incompatible change. While the bazel team tries releasing the fixed one, we can just pin the bazel version in our CentOS image until the fixed version is released. bazelbuild/bazel#8652

Risk Level: Low
Testing: manual testing

~/.ghq/github.com/envoyproxy/envoy fix-centos-build-image
✔ docker run -it envoyproxy/envoy-build-centos:`git rev-parse HEAD` bazel version
Extracting Bazel installation...
WARNING: --batch mode is deprecated. Please instead explicitly shut down your Bazel server using the command "bazel shutdown".
Build label: 0.26.1
Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Thu Jun 6 11:05:05 2019 (1559819105)
Build timestamp: 1559819105
Build timestamp as int: 1559819105

Docs Changes: N/A
Release Notes: N/A
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Taiki Ono taiki@tetrate.io

Signed-off-by: Taiki Ono <taiki@tetrate.io>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just wait it out? Bazel team say they are doing the new build, can we get an ETA from them?

@htuch htuch self-assigned this Jun 27, 2019
@taiki45
Copy link
Member Author

taiki45 commented Jun 27, 2019

Yes, we can also wait for that release. I thought this is a trivial fix and it's better than leaving the build image broken (probably for days though).

@taiki45
Copy link
Member Author

taiki45 commented Jun 27, 2019

hmm, +1 to waiting for the release.

@taiki45 taiki45 closed this Jun 27, 2019
@taiki45 taiki45 deleted the fix-centos-build-image branch June 27, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants