http fault: add active fault stat and overflow setting #6167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Add stat to track number of active injected faults 2) Add config/runtime control over how many concurrent faults can be injected. This is useful in cases where we want to allow 100% fault injection, but want to protect against too many concurrent requests using too many resources. 3) Add stat for faults that overflowed. 4) Misc code cleanup / modernization. Part of #5942. Signed-off-by: Matt Klein <mklein@lyft.com>
|
@rshriram do you mind taking a first pass? |
|
cc @goaway |
rshriram
reviewed
Mar 5, 2019
rshriram
reviewed
Mar 5, 2019
rshriram
reviewed
Mar 5, 2019
rshriram
reviewed
Mar 5, 2019
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
rshriram
previously approved these changes
Mar 7, 2019
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
htuch
reviewed
Mar 8, 2019
Signed-off-by: Matt Klein <mklein@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faults can be injected. This is useful in cases where
we want to allow 100% fault injection, but want to
protect against too many concurrent requests using too
many resources.
Part of #5942.
Risk Level: Low
Testing: New UTs (note I plan on adding fault integration tests in a follow up change)
Docs Changes: Added
Release Notes: Added