Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Move the JNI initialization and shutdown into separate functions #38499

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

fredyw
Copy link
Member

@fredyw fredyw commented Feb 20, 2025

This is needed so that we can initialize and shutdown the JNI code in a custom JNI_OnLoad and JNI_OnUnLoad.

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: android

Signed-off-by: Fredy Wijaya <fredyw@google.com>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38499 was opened by fredyw.

see: more, trace.

@fredyw
Copy link
Member Author

fredyw commented Feb 20, 2025

/retest

@fredyw fredyw marked this pull request as ready for review February 20, 2025 01:07
@fredyw
Copy link
Member Author

fredyw commented Feb 20, 2025

/assign @abeyad

@fredyw fredyw changed the title mobile: Move the JNI initialization into a separate function mobile: Move the JNI initialization and shutdown into separate functions Feb 20, 2025
@abeyad abeyad merged commit 5098cae into envoyproxy:main Feb 20, 2025
24 checks passed
@fredyw fredyw deleted the jni_init branch February 20, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants