golang: allow flushing buffer when processing the data asynchronously #37958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
|
The failure of CI is caused by low coverage of https://github.com/envoyproxy/envoy/actions/runs/12707270169 The CI on main branch also failed because of this: |
|
see #37959 |
phlax
reviewed
Jan 10, 2025
| @@ -90,6 +90,16 @@ updates: | |||
| interval: daily | |||
| time: "06:00" | |||
|
|
|||
| - package-ecosystem: "gomod" | |||
| directory: "/contrib/golang/filters/http/test/test_data/buffer_flush" | |||
There was a problem hiding this comment.
@spacewander there is a current conversation about consolidating/rationalizing these deps to one
currently the go test deps all contain the same deps and whenever they change (ie protobuf) we get an avalanche of dependency updates (and ci)
any chance we could address this first? cc @doujiang24
There was a problem hiding this comment.
#37962 has landed - so iiuc this bit should no longer be necessary
|
/wait (for CI) |
|
Surpassed by #38362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: golang: allow flushing buffer when processing the data asynchronously
Additional Description: This PR adds a feature that allows users to flush the data immediately when processing the data asynchronously.
Risk Level: Low
Testing: Integration test
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]