Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typos and minor clarifications to oauth2 http filter #35581

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

skiptomyliu
Copy link
Contributor

Commit Message: Minor comment and typo fixes for oauth2 http filter
Additional Description:
Risk Level: None
Testing: None
Docs Changes: No changes to code, just typo fixes.
Release Notes: None
Platform Specific Features: None

Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/35581/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: #35581 was opened by skiptomyliu.

see: more, trace.

Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #35581 was opened by skiptomyliu.

see: more, trace.

Signed-off-by: Dean Liu <dliu@lyft.com>
@phlax phlax self-assigned this Aug 3, 2024
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @skiptomyliu

@phlax phlax enabled auto-merge (squash) August 3, 2024 18:22
@phlax phlax merged commit b5bbfba into envoyproxy:main Aug 3, 2024
50 of 51 checks passed
martinduke pushed a commit to martinduke/envoy that referenced this pull request Aug 8, 2024
…y#35581)

Signed-off-by: Dean Liu <dliu@lyft.com>
Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
asingh-g pushed a commit to asingh-g/envoy that referenced this pull request Aug 20, 2024
…y#35581)

Signed-off-by: Dean Liu <dliu@lyft.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants