[bp/1.29] Backport deps: updates QUICHE to incorporate fixes #32443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
/assign @RyanTheOptimist |
RyanTheOptimist
requested changes
Feb 16, 2024
pref on main first please also seems there is a DCO issue |
|
Looks like this needs a DCO fix. And please update the changelog as well. |
|
/lgtm deps |
https://github.com/google/quiche/compare/83a9e8129..9e8759380 ``` $ git log 83a9e8129..9e8759380 --date=short --no-merges --format="%ad %al %s" 2024-02-15 birenroy Fixes handling of DATA frame padding in OgHttp2Session. 2024-02-15 birenroy Adds a test case demonstrating that OgHttp2Adapter does not consider DATA frame padding as "consumed". 2024-02-14 quiche-dev Fix issues when building more Quiche tests for iOS and Windows 2024-02-14 martinduke Fix test flake in MoqtSubscribeWindows. 2024-02-14 martinduke Remove #ifdef MOQT_AUTH_INFO. Also eliminate an old reference to subscribe_request 2024-02-14 martinduke Fix error in MoQT Relative Location encoding. 2024-02-14 quiche-dev Prospectively fix Chromium build 2024-02-13 quiche-dev No public description 2024-02-13 martinduke Process incoming Unsubscribes. 2024-02-13 quiche-dev Fix issues required to build additional Quiche tests for Chrome 2024-02-12 renjietang Add 2 counters for number of successful multi-port probes. 2024-02-12 dschinazi Remove unused connect-udp-version 2024-02-09 quiche-dev Fix flaky //third_party/quic/core/batch_writer:quic_batch_writer_test 2024-02-09 quiche-dev Fix spelling 2024-02-09 rch Add a comment to kBBRv2 which explains that it's essentially BBRv3 and a TODO to rename it when the implementation is complete. 2024-02-08 danzh Change QuicConnection::cipher_id() to get underlying cipher id differently. 2024-02-08 rch Always disable the QPACK dyanmic table for Hyperloop connections. 2024-02-08 martinduke Handle MoQT Objects that arrive before SUBSCRIBE_OK. 2024-02-07 bnc No public description 2024-02-06 martinduke Deprecate gfe2_restart_flag_quic_receive_ecn3. 2024-02-05 martinduke No public description 2024-02-05 martinduke Update four-pass algorithm to reduce copying and conform to draft-ietf-quic-load-balancers-19. 2024-02-05 vasilvv No public description 2024-02-02 birenroy Demotes some noisy debug logging to VLOG. 2024-02-02 bnc Merge quic_protocol_flags_list.h into quiche_protocol_flags_list.h. 2024-02-02 martinduke MOQT Message formats from draft-02. 2024-02-01 rch Add a QUIC protocol flag to not require the the kSPAD connection option in order to use QUIC server preferred address support. quic_always_support_server_preferred_address defaults to false to match existing behavior but may be set to true. This will make it easier for QUICHE servers to support non-QUICHE clients using server preferred address. 2024-01-31 bnc Remove support for QUICHE protocol flags having different internal and external values. 2024-01-31 rch Disable Huffman encoding for QPACK headers sent over Hyperloop. 2024-01-30 vasilvv Add an option to buffer data unconditionally for WebTransport. 2024-01-26 wub Add gfe2::test::SimpleClient::MaybeConfigureSocket to configure the socket fd after it is created. 2024-01-25 martinduke Report the correct error when parameter length mismatches, and pipe error type code through the ParsingError() functions. 2024-01-25 martinduke Use MOQT standard SubscribeError codes from draft-02. 2024-01-25 martinduke Clean up MoQT error cases: 2024-01-24 birenroy Uses constexpr to improve header validation code generation. Thank you to ricea@google.com for the suggestion! 2024-01-23 vasilvv Fix ODR violtions in quic/core 2024-01-23 wub No public description 2024-01-22 vasilvv Fix standalone QUICHE build 2024-01-22 martinduke Exit function early on QUIC_BUG. Verified to fix the repro. 2024-01-20 dschinazi Allow masque_server to check signature auth on GET requests 2024-01-19 dschinazi Add GET request support to MASQUE client code 2024-01-19 bnc Use NumBytesConsumed() to determine number of bytes associated with request. 2024-01-19 martinduke Reduce QUIC load balancer copies by passing the result as an argument. 2024-01-19 danzh Add a new platform API QuicheScopedDisableExitOnDFatal to allow Envoy's QUIC code switching to use platform API implementation under net/quic/platform_overrides/. 2024-01-18 martinduke Move simple decryption cases out of LoadBalancerConfig. 2024-01-18 vasilvv In WebTransport over HTTP/2, implement basic stream support. 2024-01-17 diannahu Move MetadataFrameSequence from third_party/spdy/core to gfe/gfe2/metadata. 2024-01-17 renjietang Do not send RETIRE_CONNECTION_ID frame when the connection is closed. 2024-01-16 birenroy Refactoring in preparation for some changes to data frame generation. 2024-01-12 vasilvv Add code counts for legacy MESSAGE frame codepoints. ``` Signed-off-by: Biren Roy <birenroy@google.com> Updates to incorporate QUICHE changes. Signed-off-by: Biren Roy <birenroy@google.com>
d6d75f3 to
af1b6d9
Compare
Signed-off-by: Biren Roy <birenroy@google.com>
I added a note in the v1.29.1 changelog. Should I also add it to the v1.29 one? I'm not familiar with how these releases are structured. |
RyanTheOptimist
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the QUICHE dependency to incorporate fixes for #32401.
Commit Message: deps: updates QUICHE to incorporate fixes
Additional Description:
Risk Level: low
Testing: ran unit and integration tests locally
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes #32401