Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increases a test timeout to avoid flaky failures #32232

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

birenroy
Copy link
Contributor

@birenroy birenroy commented Feb 6, 2024

In my repro attempts, I saw failures with both the nghttp2 and oghttp2 codecs.

Addresses the bulk of the failures from #32132.

Tested via:

$ baze test --config=clang-tsan --config=remote test/integration:multiplexed_integration_test \
  --runs_per_test=1000 --test_filter='IpVersions/Http2FrameIntegrationTest.CloseConnectionWithDeferredStreams/*' \
  --test_sharding_strategy=disabled

With the timeout extension, I saw 1 failure in 1000 runs, which is significantly better than before.

Commit Message: Increases a test timeout to avoid flaky failures
Additional Description:
Risk Level: none, tests only
Testing: ran 1000 iterations of the suspicious test case
Docs Changes:
Release Notes:
Platform Specific Features:

…test.

Signed-off-by: Biren Roy <birenroy@google.com>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #32232 was opened by birenroy.

see: more, trace.

@birenroy birenroy marked this pull request as ready for review February 6, 2024 19:17
@birenroy
Copy link
Contributor Author

birenroy commented Feb 6, 2024

/assign @RyanTheOptimist
/assign @phlax

Copy link
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, Biren!

@alyssawilk alyssawilk merged commit 0a54177 into envoyproxy:main Feb 6, 2024
53 checks passed
phlax pushed a commit to phlax/envoy that referenced this pull request Apr 8, 2024
)

Increases the timeout for the connection close with deferred streams test.

Signed-off-by: Biren Roy <birenroy@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Apr 10, 2024
Increases the timeout for the connection close with deferred streams test.

Signed-off-by: Biren Roy <birenroy@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants