Sets an oghttp2 config option to allow different "host" and ":authority" values #29712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Biren Roy <birenroy@google.com>
Signed-off-by: Biren Roy <birenroy@google.com>
Signed-off-by: Biren Roy <birenroy@google.com>
|
/assign @diannahu |
|
/retest |
|
/assign @RyanTheOptimist |
yanavlasov
approved these changes
Sep 20, 2023
|
@birenroy the failure in the compile time options does not seem related to this PR. https://source.cloud.google.com/results/invocations/a881aa18-7dc9-4fac-b2dc-8ce62636766f/log Maybe it needs main merge? /wait |
…st-and-authority Signed-off-by: Biren Roy <birenroy@google.com>
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a codec difference between nghttp2 and oghttp2.
Repro test case in multiplexed_integration_test.cc originally by @yanavlasov.
Commit Message: Sets an oghttp2 config option to allow different "host" and ":authority" values
Additional Description:
Risk Level: low
Testing: added integration test coverage for the codec difference
Docs Changes:
Release Notes:
Platform Specific Features: