Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: fix crash when type URL doesn't match proto. #14031

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

htuch
Copy link
Member

@htuch htuch commented Nov 16, 2020

Fixes #13681.

Risk level: Low
Testing: Unit and integration regression tests added.

Signed-off-by: Harvey Tuch htuch@google.com

Fixes envoyproxy#13681.

Risk level: Low
Testing: Unit and integration regression tests added.

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch
Copy link
Member Author

htuch commented Nov 16, 2020

CC @gkleiman @mattklein123

@mattklein123 mattklein123 self-assigned this Nov 16, 2020
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@htuch htuch merged commit 0743c31 into envoyproxy:master Nov 16, 2020
@htuch htuch deleted the type-annotation-crash branch November 16, 2020 23:16
mpuncel added a commit to mpuncel/envoy that referenced this pull request Nov 18, 2020
* master: (117 commits)
  vrp: allow supervisord to open its log file (envoyproxy#14066)
  [http1] fix H/1 response pipelining (envoyproxy#13983)
  wasm: make dependency clearer (envoyproxy#14062)
  docs: updating 100-continue docs (envoyproxy#14040)
  quiche: fix stream trailer decoding issue (envoyproxy#13871)
  tidy: use last_github_commit script instead of target branch (envoyproxy#14052)
  stats: use RE2 and a better pattern to accelerate a single stats tag-extraction RE (envoyproxy#8831)
  wasm: use static registration for runtimes (envoyproxy#14014)
  grpc-json-transcoder: Add support for configuring unescaping behavior (envoyproxy#14009)
  ci: fix CodeQL-build by removing deprecated set-env command (envoyproxy#14046)
  config: fix crash when type URL doesn't match proto. (envoyproxy#14031)
  Build: Propagate user-supplied tags to external headers library. (envoyproxy#14016)
  [test host utils] use make_shared to avoid memory leaks (envoyproxy#14042)
  jwt_authn: update to jwt_verify_lib with 1 minute clock skew (envoyproxy#13872)
  quiche: update QUICHE tar (envoyproxy#13949)
  sds: improve watched directory documentation. (envoyproxy#14029)
  log the internal error message from *SSL when the cert and private key doesn't match (envoyproxy#14023)
  wasm: fix CPE for Wasmtime. (envoyproxy#14024)
  docs: Bump sphinxext-rediraffe version (envoyproxy#13996)
  CDS: remove warming cluster if CDS response desired (envoyproxy#13997)
  ...
andreyprezotto pushed a commit to andreyprezotto/envoy that referenced this pull request Nov 24, 2020
Fixes envoyproxy#13681.

Risk level: Low
Testing: Unit and integration regression tests added.

Signed-off-by: Harvey Tuch <htuch@google.com>
qqustc pushed a commit to qqustc/envoy that referenced this pull request Nov 24, 2020
Fixes envoyproxy#13681.

Risk level: Low
Testing: Unit and integration regression tests added.

Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Qin Qin <qqin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault parsing xDS response with new v3 field and v2 typeUrl
2 participants