test: refactor header inclusion to speed up building (for test/common/...) #12046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muge Chen <mugechen@google.com>
ahedberg
suggested changes
Jul 13, 2020
Signed-off-by: Muge Chen <mugechen@google.com>
|
@foreseeable the failure here seems potentially real. |
ahedberg
reviewed
Jul 16, 2020
| @@ -28,7 +29,7 @@ | |||
| #include "test/integration/fake_upstream.h" | |||
| #include "test/mocks/grpc/mocks.h" | |||
| #include "test/mocks/local_info/mocks.h" | |||
| #include "test/mocks/server/mocks.h" | |||
| #include "test/mocks/server/transport_socket_factory_context.h" | |||
There was a problem hiding this comment.
Grpc::StatNames is an incomplete type here (https://dev.azure.com/cncf/envoy/_build/results?buildId=44924&view=logs&j=ec9f720e-f904-5f65-4ba4-f371a013344f&t=ee47c280-92b1-5c80-3a10-d3d23a58a062&l=3606); we need to #include the header providing that name. server/mocks.h probably indirectly #included it before.
There was a problem hiding this comment.
yes, server/mocks.h previously #include "common/grpc/context_impl.h" which providing that name. i have sent a pr resolve this.
Signed-off-by: Muge Chen <mugechen@google.com>
junr03
approved these changes
Jul 18, 2020
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
…/...) (envoyproxy#12046) Commit Message: refactor header inclusion to speed up building (for test/common/...) Risk Level: low Testing: existing tests Docs Changes: N/A Release Notes: no Related Issues: envoyproxy#10917 Signed-off-by: Muge Chen <mugechen@google.com> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
…/...) (envoyproxy#12046) Commit Message: refactor header inclusion to speed up building (for test/common/...) Risk Level: low Testing: existing tests Docs Changes: N/A Release Notes: no Related Issues: envoyproxy#10917 Signed-off-by: Muge Chen <mugechen@google.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Muge Chen mugechen@google.com
Refactor mock class include directive after dividing test/server/mocks.h (#11649)
Since the refactoring affects ~100 files so I split it up to several pull requests (previous one #11952 #12045)
Building time comparison for affected tests: see spreadsheet at #10917 comment
Commit Message: refactor header inclusion to speed up building
Additional Description:
Risk Level: low
Testing: exsiting tests
Docs Changes: N/A
Release Notes: no
Related Issues: #10917
\cc @ahedberg @bbarenblat