conn_pool: unifying status codes #10854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
2773a2f to
7839a80
Compare
zuercher
reviewed
Apr 20, 2020
source/common/http/conn_pool_base.h
Outdated
| @@ -89,6 +89,7 @@ class ConnPoolImplBase : public ConnectionPool::Instance, | |||
| Stats::TimespanPtr conn_length_; | |||
| Event::TimerPtr connect_timer_; | |||
| bool resources_released_{false}; | |||
| bool timed_out_{true}; | |||
There was a problem hiding this comment.
Should this be initialized false? (I don't see anything that clears, so I think every failure in onConnectionEvent will report a time out?
There was a problem hiding this comment.
gack, that was not supposed to be part of the commit. That's the ASSERT-fail moral equivalent of "surely tests will fail if I set this wrong" which they surprisingly didn't. And now we have tests that will fail :-)
penguingao
pushed a commit
to penguingao/envoy
that referenced
this pull request
Apr 22, 2020
Risk Level: Medium (minor HTTP/TCP refactor) Testing: unit tests Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: pengg <pengg@google.com>
This was referenced Mar 3, 2021
alyssawilk
added a commit
that referenced
this pull request
Mar 3, 2021
#10854 inadvertently changed the behavior of connect timeouts. This reinstates prior behavior. Risk Level: Low (reinstating prior behavior) Testing: added regression test Docs Changes: n/a Release Notes: inline Signed-off-by: Shikugawa <rei@tetrate.io> Co-authored-by: alyssawilk <alyssar@chromium.org>
alyssawilk
added a commit
that referenced
this pull request
Mar 3, 2021
#10854 inadvertently changed the behavior of connect timeouts. This reinstates prior behavior. Risk Level: Low (reinstating prior behavior) Testing: added regression test Docs Changes: n/a Release Notes: inline Signed-off-by: Shikugawa <rei@tetrate.io> Co-authored-by: alyssawilk <alyssar@chromium.org>
alyssawilk
pushed a commit
that referenced
this pull request
Mar 3, 2021
#10854 inadvertently changed the behavior of connect timeouts. This reinstates prior behavior. Risk Level: Low (reinstating prior behavior) Testing: added regression test Docs Changes: n/a Release Notes: inline Signed-off-by: Shikugawa <rei@tetrate.io> Co-authored-by: alyssawilk <alyssar@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: Medium (minor HTTP/TCP refactor)
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a