Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove persistent envoy.reloadable_features.http2_protocol_options values #8993

Closed
alyssawilk opened this issue Nov 12, 2019 · 4 comments · Fixed by #9783
Closed

remove persistent envoy.reloadable_features.http2_protocol_options values #8993

alyssawilk opened this issue Nov 12, 2019 · 4 comments · Fixed by #9783
Assignees
@alyssawilk
Labels
no stalebot Disables stalebot from closing an issue tech debt
Milestone
1.14.0

Comments

@alyssawilk
Copy link
Contributor

As discussed on #8849 the http protocol options values don't really mesh with the rest of the reloadable features. Since we want to keep them around long term we should probably rename.

@yanavlasov can you pick this up some time in the next couple of months?
@alyssawilk alyssawilk added tech debt no stalebot Disables stalebot from closing an issue labels Nov 12, 2019
@mattklein123
Copy link
Member

Per discussion in the other PR I think we now agreed we are going to delete them? cc @PiotrSikora

@PiotrSikora
Copy link
Contributor

Yup, let's just remove them.

@alyssawilk alyssawilk changed the title rename persistent envoy.reloadable_features.http2_protocol_options values remove persistent envoy.reloadable_features.http2_protocol_options values Nov 13, 2019
@alyssawilk
Copy link
Contributor Author

As mentioned on 8849 we'll punt this to after the next release. It's already no-stalebot so we'll check back in after the holidays :-)

@alyssawilk alyssawilk assigned alyssawilk and unassigned yanavlasov Dec 2, 2019
@alyssawilk
Copy link
Contributor Author

I'll take this one back as there's a couple of other flags and some associated clean up.

@mattklein123 mattklein123 added this to the 1.13.0 milestone Dec 10, 2019
@htuch htuch modified the milestones: 1.13.0, 1.14.0 Jan 16, 2020
@alyssawilk alyssawilk mentioned this issue Jan 22, 2020
Merged
alyssawilk added a commit that referenced this issue Jan 27, 2020
@alyssawilk
http2: removing legacy configuration options (#9783)
f57e280 
Removing some configuration knobs which were intended to be temporary runtime override knobs for high risk security fixes. They've been running in prod so far so good. Time to clean up.

Risk Level: Medium (someone could have missed they were temporary)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Fixes #8993

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
1.14.0
Development

Successfully merging a pull request may close this issue.

http2: removing legacy configuration options alyssawilk/envoy
5 participants
@PiotrSikora @mattklein123 @yanavlasov @htuch @alyssawilk