Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit handling of addresses when listener filters (proxy protocol, etc) modify it #14133

Closed
ggreenway opened this issue Nov 21, 2020 · 1 comment · Fixed by #14432
Closed

Audit handling of addresses when listener filters (proxy protocol, etc) modify it #14133

ggreenway opened this issue Nov 21, 2020 · 1 comment · Fixed by #14432
Assignees
@mattklein123
Labels
area/connection help wanted Needs help! tech debt
Milestone
1.17.0

Comments

@ggreenway
Copy link
Contributor

The handling of downstreamLocalAddress and downstreamRemoteAddress is messy and unclear. Audit uses of the address on both the connection and StreamInfo. Clean up code so it is easier to understand.

  • Specifically, the addresses are set twice on the connection StreamInfo, once before listener filters are run and once after. Try to find a better way to handle this.
  • HCM sets the downstream address before doing XFF handling. Can this be removed?
@ggreenway ggreenway mentioned this issue Nov 21, 2020
Merged
@mattklein123 mattklein123 self-assigned this Nov 22, 2020
@mattklein123 mattklein123 added this to the 1.17.0 milestone Nov 22, 2020
mattklein123 added a commit that referenced this issue Dec 16, 2020
@mattklein123
stream info: cleanup address handling
06008a9 
Consolidate all downstream address handling setting into a single
function. Also remove duplicate setting in the connection handler.
This should make this logic less error prone than it was previously.

Fixes #14133

Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123 mattklein123 mentioned this issue Dec 16, 2020
Merged
mattklein123 added a commit that referenced this issue Jan 7, 2021
@mattklein123
stream info: cleanup address handling (#14432)
659f2ea 
Consolidate all downstream address handling setting into a single
function. Also remove duplicate setting in the connection handler.
This should make this logic less error prone than it was previously.

Fixes #14133

Signed-off-by: Matt Klein <mklein@lyft.com>
@rgs1
Copy link
Member

rgs1 commented Jan 11, 2021

Related: #14432 (comment).

@soulxu soulxu mentioned this issue Jun 8, 2021
Merged
@soulxu soulxu mentioned this issue Jun 28, 2021
Closed
rexengineering pushed a commit to rexengineering/istio-envoy that referenced this issue Oct 15, 2021
@mattklein123
stream info: cleanup address handling (#14432)
3dd073d 
Consolidate all downstream address handling setting into a single
function. Also remove duplicate setting in the connection handler.
This should make this logic less error prone than it was previously.

Fixes envoyproxy/envoy#14133

Signed-off-by: Matt Klein <mklein@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattklein123 mattklein123

Labels
area/connection help wanted Needs help! tech debt
Projects
None yet
Milestone
1.17.0
Development

Successfully merging a pull request may close this issue.

stream info: cleanup address handling envoyproxy/envoy
3 participants
@rgs1 @mattklein123 @ggreenway