Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve shellcheck error output in CI #13709

Closed
phlax opened this issue Oct 22, 2020 · 0 comments · Fixed by #13710
Closed

Improve shellcheck error output in CI #13709

phlax opened this issue Oct 22, 2020 · 0 comments · Fixed by #13710
Labels
area/build enhancement Feature requests. Not bugs or questions.

Comments

@phlax
Copy link
Member

phlax commented Oct 22, 2020

description

atm, if shellcheck fails in format CI its hard to know that is the problem (unless you know that shellcheck is the other thing that can fail)

i guess we need to catch the shellcheck return code and add some info at bottom of CI if it failed
@phlax phlax added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Oct 22, 2020
This was referenced Oct 22, 2020
Merged
Merged
@asraa asraa added area/build and removed triage Issue requires triage labels Oct 22, 2020
lizan pushed a commit that referenced this issue Oct 23, 2020
@phlax
ci: Improve shellcheck fail output (#13710)
706d42c 
Fix #13709

Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Improve shellcheck fail output phlax/envoy
2 participants
@phlax @asraa