remove std::get linter

Signed-off-by: Michael Rebello <me@michaelrebello.com>
envoyproxy · Sep 10, 2020 · a93b02a · a93b02a
1 parent 1b0744b
commit a93b02a
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 11 deletions.
diff --git a/tools/code_format/check_format.py b/tools/code_format/check_format.py
@@ -692,8 +692,6 @@ def checkSourceLine(line, file_path, reportError):
   # See: https://github.com/envoyproxy/envoy/issues/12341
   if tokenInLine("std::any", line):
     reportError("Don't use std::any; use absl::any instead")
-  if tokenInLine("std::get", line):
-    reportError("Don't use std::get; use absl::get instead")
   if tokenInLine("std::get_if", line):
     reportError("Don't use std::get_if; use absl::get_if instead")
   if tokenInLine("std::holds_alternative", line):

diff --git a/tools/code_format/check_format_test_helper.py b/tools/code_format/check_format_test_helper.py
@@ -243,7 +243,6 @@ def runChecks():
       "std_unordered_set.cc", "Don't use std::unordered_set; use absl::flat_hash_set instead " +
       "or absl::node_hash_set if pointer stability of keys/values is required")
   errors += checkUnfixableError("std_any.cc", "Don't use std::any; use absl::any instead")
-  errors += checkUnfixableError("std_get.cc", "Don't use std::get; use absl::get instead")
   errors += checkUnfixableError("std_get_if.cc", "Don't use std::get_if; use absl::get_if instead")
   errors += checkUnfixableError("std_holds_alternative.cc",
                                 "Don't use std::holds_alternative; use absl::holds_alternative instead")

diff --git a/tools/testdata/.DS_Store b/tools/testdata/.DS_Store
diff --git a/tools/testdata/check_format/std_get.cc b/tools/testdata/check_format/std_get.cc