Skip to content

Commit

Permalink
pr template: add docs changes optional link, misc enhancements (#2149)
Browse files Browse the repository at this point in the history
Signed-off-by: Jose Nino <jnino@lyft.com>
  • Loading branch information
junr03 authored and htuch committed Dec 4, 2017
1 parent 9014a60 commit 762027f
Showing 1 changed file with 16 additions and 10 deletions.
26 changes: 16 additions & 10 deletions PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,12 @@
* router:add x-envoy-overloaded header
* tls: add support for specifying TLS session ticket keys


*Description*:
>What does this PR do? What was the behavior before the PR?
What is the behavior with the PR? If fixing a bug, please describe what
the original issue is and how the change resolves it. How does this
feature get enabled? By default, config change, etc...

[Optional Fixes #Issue]

[Optional *API Changes*:]
>Link to [Data Plane PR](https://github.com/envoyproxy/data-plane-api/pulls)]
*Risk Level*: Low | Medium | High
>Low: Small bug fix or small optional feature.
Expand All @@ -41,8 +35,20 @@ forms of testing, please use your best judgement or ask for guidance
if you are unsure. A good rule of thumb is the riskier the change, the
more comprehensive the testing should be.

[optional *Deprecated*:]
> Description of what is deprecated.
*Docs Changes*:
>Link to [Data Plane PR](https://github.com/envoyproxy/data-plane-api/pulls)]
if your PR involves documentation changes. Please write in N/A if there were no
documentation changes.

*Release Notes*:
>If this change is user impacting you **must** add a release note to
[RAW_RELEASE_NOTES.md](RAW_RELEASE_NOTES.md). Thank you! Please write in N/A if
there are no release notes.

[Optional Fixes #Issue]

[Optional *API Changes*:]
>Link to [Data Plane PR](https://github.com/envoyproxy/data-plane-api/pulls)]
[optional *Release Notes*:] If this change is user impacting you **must** add a release note to
[RAW_RELEASE_NOTES.md](RAW_RELEASE_NOTES.md). Thank you!
[Optional *Deprecated*:]
>Description of what is deprecated.

0 comments on commit 762027f

Please sign in to comment.