Skip to content

Commit

Permalink
secret-provider: update thread_local update method comment (#38459)
Browse files Browse the repository at this point in the history
Signed-off-by: Boteng Yao <boteng@google.com>
  • Loading branch information
botengyao authored Feb 21, 2025
1 parent 60aed1c commit 65e24b8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion source/common/secret/secret_provider_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ ThreadLocalGenericSecretProvider::ThreadLocalGenericSecretProvider(

const std::string& ThreadLocalGenericSecretProvider::secret() const { return (*tls_)->value_; }

// This function is executed on the main during xDS update and can throw.
// This function is executed on the main during xDS update.
absl::Status ThreadLocalGenericSecretProvider::update() {
ASSERT_IS_MAIN_OR_TEST_THREAD();
std::string value;
if (const auto* secret = provider_->secret(); secret != nullptr) {
auto value_or_error = Config::DataSource::read(secret->secret(), true, api_);
Expand Down

0 comments on commit 65e24b8

Please sign in to comment.