feat!: set default available from to next month #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend
|
||||||||||||||||||||||||||||
| Project |
frontend
|
| Branch Review |
feat/available-from-default-next-month
|
| Run status |
|
| Run duration | 01m 40s |
| Commit |
|
| Committer | morre |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
32
|
| View all changes introduced in this branch ↗︎ | |
a78c3e4 to
1e7a2c6
Compare
With this, the default AvailableFrom date is set to the first of the month following the transaction, not the month of the transaction. This makes more sense logically since it enforces funds to only be allocated after they have been received by default. The value can still be explicitly set if that is required. The onChange function now just keeps the existing value and does not try to set it to the first of the next month, since that would set a future date every time the field is edited.
1e7a2c6 to
b101789
Compare
malfynnction
approved these changes
Nov 23, 2024
frontend
|
||||||||||||||||||||||||||||
| Project |
frontend
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 01m 40s |
| Commit |
|
| Committer | Morre |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
32
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the default AvailableFrom date is set to the first of the month following the transaction, not the month of the transaction.
This makes more sense logically since it enforces funds to only be allocated after they have been received by default.
The value can still be explicitly set if that is required.