Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only build arm image on release, do not block image build with other jobs #1758

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

morremeyer
Copy link
Member

With this change, image builds for arm64 are only run for tags, speeding up PR testing significantly (the arm64 build takes > 5 minutes).

The image build now also does not wait for pre-commit and cypress to finish anymore, since releases are only made when both are successful anyways.

@morremeyer morremeyer requested a review from a team as a code owner November 23, 2024 14:48
@morremeyer morremeyer force-pushed the ci/only-build-arm-on-release branch from b4d2a7b to 0969376 Compare November 23, 2024 14:50
Copy link

cypress bot commented Nov 23, 2024

frontend    Run #1841

Run Properties:  status check passed Passed #1841  •  git commit ae6c264bcd ℹ️: Merge 0969376eef2fe0cf705b6ca890d3e028c324a5e8 into 64b71478324934cc37aa48f757d0...
Project frontend
Branch Review ci/only-build-arm-on-release
Run status status check passed Passed #1841
Run duration 01m 45s
Commit git commit ae6c264bcd ℹ️: Merge 0969376eef2fe0cf705b6ca890d3e028c324a5e8 into 64b71478324934cc37aa48f757d0...
Committer morre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 32
View all changes introduced in this branch ↗︎

@morremeyer morremeyer enabled auto-merge (squash) November 23, 2024 14:51
@morremeyer morremeyer merged commit 064baca into main Nov 23, 2024
11 checks passed
@morremeyer morremeyer deleted the ci/only-build-arm-on-release branch November 23, 2024 14:55
Copy link

cypress bot commented Nov 23, 2024

frontend    Run #1845

Run Properties:  status check passed Passed #1845  •  git commit 064baca788: ci: only build arm image on release, do not block image build with other jobs (#...
Project frontend
Branch Review main
Run status status check passed Passed #1845
Run duration 01m 39s
Commit git commit 064baca788: ci: only build arm image on release, do not block image build with other jobs (#...
Committer morre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 32
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant