fix: consider income in recent envelopes #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
With this, income is considered in the recent envelopes. In the recent envelopes, income is represented as a recent envelope with the ID `null`. Therefore, we need to check for this specific case and not use it as suggestion when it is the first in the list of recent envelopes. We also need to remove it from the recent envelopes list.
60b74b2 to
cfc58c7
Compare
|
Paired with @malfynnction on this, therefore there's no explicit approval of the PR. |
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, income is considered in the recent envelopes.
In the recent envelopes, income is represented as a recent envelope with the ID
null.Therefore, we need to check for this specific case and not use it as suggestion when it is the first
in the list of recent envelopes.
We also need to remove it from the recent envelopes list.