Skip to content

Commit

Permalink
chore(deps): install ynap-parsers from npmjs
Browse files Browse the repository at this point in the history
This will make maintenance and contributions easier.

Since envelope-zero/you-need-a-parser now publishes exclusively to npmjs, we need to update this anyways.

Resolves #1559.
  • Loading branch information
morremeyer committed Mar 2, 2024
1 parent 8a8a52c commit c4baa67
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 30 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ jobs:
node-version: '20'
cache: 'npm'

- name: set npm auth
run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.GITHUB_TOKEN }}" >> ~/.npmrc

- name: install node modules
run: npm ci

Expand Down Expand Up @@ -70,9 +67,6 @@ jobs:
- name: Checkout
uses: actions/checkout@v4.1.1

- name: Set npm auth
run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.GITHUB_TOKEN }}" >> ~/.npmrc

- name: Run cypress
uses: cypress-io/github-action@v6.6.1
with:
Expand Down Expand Up @@ -137,4 +131,3 @@ jobs:
labels: ${{ steps.meta.outputs.labels }}
build-args: |
VITE_VERSION=${{ github.ref_name }}
GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }}
1 change: 0 additions & 1 deletion .npmrc

This file was deleted.

1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ Contributions are welcome. Please note the [Code of Conduct](CODE_OF_CONDUCT.md)
You will need to:

- Install [pre-commit](https://pre-commit.com/)
- Set up a GitHub Personal Access Token to read from the GitHub package repository. Follow the steps in https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-npm-registry#authenticating-with-a-personal-access-token.

Once these steps are done, run `make setup` to perform the repository setup.

Expand Down
4 changes: 1 addition & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ WORKDIR /app
COPY package.json package-lock.json /app/
COPY patches /app/patches

ARG GITHUB_TOKEN
RUN echo "//npm.pkg.github.com/:_authToken=${GITHUB_TOKEN}" >> ~/.npmrc && \
npm install --production
RUN npm install --production

# Copy app files
COPY src /app/src
Expand Down
33 changes: 16 additions & 17 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "envelope-zero-frontend",
"dependencies": {
"@envelope-zero/ynap-parsers": "1.17.1",
"@envelope-zero/ynap-parsers": "1.17.3",
"@headlessui/react": "1.7.18",
"@heroicons/react": "2.1.1",
"@tailwindcss/forms": "0.5.7",
Expand Down

0 comments on commit c4baa67

Please sign in to comment.