Crate name refactor #561
Merged
Crate name refactor #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be more accurate
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HCastano
commented
Dec 13, 2023
| @@ -1,4 +1,6 @@ | |||
| [profile.release] | |||
There was a problem hiding this comment.
We may want to add this back at some point, but actually populate it
JesseAbram
approved these changes
Dec 13, 2023
ameba23
approved these changes
Dec 13, 2023
| @@ -122,7 +122,7 @@ jobs: | |||
| - release | |||
|
|
|||
| parameters: | |||
| crypto: | |||
| crates: | |||
There was a problem hiding this comment.
Im happy with crates - but another possibilty would be tss-server or just tss since these crates are all related to or dependecies of entropy-tss.
There was a problem hiding this comment.
I wanted to keep it a bit generic since there are some crates used in both, and we could potentially have "standalone" crates that just happen to be part of the monorepo here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our crate names and folder structure a bit in preparation for publishing.
The main changes introduced are:
cryptofolder is nowcratescratesare all now prefixed withentropy-serverbinary has been renamed toentropy-tsson crates.io
entropyxyz/entropy-tssafterthis!
I hope this doesn't cause too much churn 😅
cc @vitropy @frankiebee @jawndiego