Auxiliary data for program evaluation #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
933efd8 to
d75ed57
Compare
JesseAbram
approved these changes
Nov 3, 2023
|
(I'm gonna take a look at this in a couple of hours, don't merge it in yet 🙏) |
HCastano
reviewed
Nov 3, 2023
|
(Changed the title since we don't use conventional commits) |
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
4b66671 to
089c711
Compare
HCastano
reviewed
Nov 6, 2023
ameba23
approved these changes
Nov 7, 2023
jakehemmerle
commented
Nov 8, 2023
HCastano
approved these changes
Nov 8, 2023
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
ameba23
added a commit
that referenced
this pull request
Nov 14, 2023
* master: Integration test for validator joining network (#493) Add `ENTROPY_NODE` environment variable (#497) Change `SocketAddr` type for `String` (#496) Allow big protocol messages (#495) Add test for `EncryptedConnection` (#494) Use bincode rather than JSON for protocol and subscribe messages (#492) Remark on possible need to address TSS server from the Docker host. (#490) no proactive refresh on private key visibility (#485) Auxiliary data for program evaluation (#475) Validate proactive refresh endpoint (#483)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows programs to include an auxiliary data field, which can include data relevant to the evaluation of the program (eg zero knowledge proofs, third party signatures), but data that should not be part of the actual message that will be signed.
@frankiebee @jawndiego This changes the JSON payload body of the
/sign_txendpoint as follows:transaction_requestis renamed tomessageauxilary_datais a hex encoded string (just likemessage) of the extra data the user might want to include in their signature request