Fix master build #1079
Fix master build #1079
Conversation
| got_jumpstart_event = true; | ||
| break; | ||
| }; | ||
| assert_eq!(format!("{:?}", jump_start_status), format!("{:?}", JumpStartStatus::Done)); |
There was a problem hiding this comment.
This will always be true, but no harm in leaving it in
There was a problem hiding this comment.
🥇 Great that this works and CI is passing again.
I don't totally understand why it works. I am guessing it must be that sometimes the jumpstart finished event was happening whilst we were waiting for the http responses, and so we were missing it.
run_to_block(&rpc, block_number + 9).await;
This feels like something which could break again easily when something changes either with the protocol or the hardware we run the tests on.
I feel like we keep getting problems in tests relating to mocking the OCW requests (eg the test_store_share test). I know you disagree but i think the way to go is to only mock these when you are specifically testing the behavior of that http endpoint.
this should be fine this was because we.....I upped the refresh sent block from 5 to 7, so this created a race condition, now it should be good.
mmmm fair we can bring it up on our next core meeting, |
* master: Bump clap from 4.5.18 to 4.5.19 in the patch-dependencies group (#1091) Avoid panic by checking that we have a non-signing validator before selecting one (#1083) Fix master build (#1088) Small fixes to `test-cli` (#1084) Pregenerate keyshares sets for all possible initial signer comittees (#1073) Fix master build (#1079) Bump reqwest from 0.12.7 to 0.12.8 in the patch-dependencies group (#1082) Block tss chain when signer (#1078) Run multiple test validator (#1074) Bump tempfile from 3.12.0 to 3.13.0 (#1076) Bump axum from 0.7.6 to 0.7.7 in the patch-dependencies group (#1075) Unignore register and sign integration test, and do a non-mock jumpstart (#1070) No unbonding when signer or next signer (#1031) Add `/relay_tx` endpoint (#1050) Fix how pre-generated keyshares are added for tests (#1061) Handle Provisioning Certification Keys (PCKs) (#1051) Bump async-trait from 0.1.82 to 0.1.83 in the patch-dependencies group (#1067)
Fixes master build by not querying potentially missed event then repinging until the event block had been pruned, this instead just goes to non pruning state of the chain