Refactor PrefixMap and PrefixList validation for clarity #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
commented
Mar 23, 2020
| @@ -47,8 +48,14 @@ class Person(HasTraits): | |||
| with self.assertRaises(TraitError): | |||
| person.married = "ye" | |||
|
|
|||
| with self.assertRaises(TraitError): | |||
There was a problem hiding this comment.
Removed because this is now covered in the test_bad_types test.
midhun-pm
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
PrefixMap.validateandPrefixList.validatemethods for simplicity, clarity and consistency with each other.Along the way, it fixes #955 and #957.
Additional tests on the way.No API changes, so no documentation updates or stub updates needed. Tests added. I didn't add a regression test specifically for #955 (the nested exception) since I don't think we should ever really care much in code whether an exception arises from another one; it's more of a cosmetic issue for those seeing the exception.