Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test for #906 #910

Closed
wants to merge 4 commits into from
Closed

Conversation

mdickinson
Copy link
Member

Do not merge: this is an example regression test for #906. If it fails in the expected way, I'll merge this branch into the branch for #907.

@mdickinson
Copy link
Member Author

Yay! Expected segfaults all around.

@codecov-io
Copy link

codecov-io commented Feb 28, 2020

Codecov Report

Merging #910 into master will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
+ Coverage   72.59%   72.89%   +0.29%     
==========================================
  Files          51       51              
  Lines        6474     6474              
  Branches     1302     1302              
==========================================
+ Hits         4700     4719      +19     
+ Misses       1378     1355      -23     
- Partials      396      400       +4
Impacted Files Coverage Δ
traits/editor_factories.py 81.25% <0%> (-3.13%) ⬇️
traits/trait_types.py 71.07% <0%> (-0.16%) ⬇️
traits/has_traits.py 70.72% <0%> (+0.33%) ⬆️
traits/traits.py 76.92% <0%> (+4.04%) ⬆️
traits/etsconfig/etsconfig.py 63.8% <0%> (+6.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8a9b1...4548a24. Read the comment docs.

@mdickinson mdickinson closed this Feb 28, 2020
@mdickinson mdickinson deleted the test/regression-test-for-906 branch February 28, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants