-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert Enum default computation #828
Conversation
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
========================================
Coverage ? 72.4%
========================================
Files ? 51
Lines ? 6367
Branches ? 1276
========================================
Hits ? 4610
Misses ? 1363
Partials ? 394
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #835 for a full proposal. |
Yes it does! Thanks both! |
Revert enum defaults to using index 0 except for
enum.Enum
s, which instead use the first value returned from the iterator.This restores the default behaviour to exactly what it was before the introduction of support for
enum.Enum
other than special-casing default values forenum.Enum
.