Fix validation of Callable in a compound trait #798
Merged
+35
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
commented
Jan 23, 2020
| @@ -4223,7 +4229,7 @@ static int | |||
| _set_trait_comparison_mode(trait_object *trait, PyObject *value, void *closure) | |||
| { | |||
| long comparison_mode = PyLong_AsLong(value); | |||
|
|
|||
There was a problem hiding this comment.
VS Code did this, not me! (Apparently there was some trailing whitespace in ctraits.c)
mdickinson
commented
Jan 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #798 +/- ##
=========================================
Coverage ? 72.41%
=========================================
Files ? 51
Lines ? 6363
Branches ? 1274
=========================================
Hits ? 4608
Misses ? 1362
Partials ? 393Continue to review full report at Codecov.
|
|
Yes I can review. Thank you for fixing it! |
kitchoi
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix validation of a
Callabletrait inside anEither.Fixes #793