Add BaseCallable trait type #795
Conversation
There was a problem hiding this comment.
Looks good, but please could we have a unit test?
A test that subclasses BaseCallable to modify the validation would be ideal, since that's what motivates the addition of BaseCallable. E.g., you could try writing a ZeroArgsCallable subclass of BaseCallable that verifies (using the inspect module) that the callable takes no arguments.
|
I added the suggested test case. |
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
=========================================
Coverage ? 73.54%
=========================================
Files ? 51
Lines ? 7148
Branches ? 1477
=========================================
Hits ? 5257
Misses ? 1481
Partials ? 410
Continue to review full report at Codecov.
|
|
Thank you! Please could we also have a test that covers basic use of |
| def test_override_validate(self): | ||
|
|
||
| class ZeroArgsCallable(BaseCallable): | ||
|
|
There was a problem hiding this comment.
It would be good to have an explanatory docstring on this class.
traits/tests/test_callable.py
Outdated
|
|
||
| def validate(self, object, name, value): | ||
| if callable(value): | ||
| sig = Signature.from_callable(value) |
There was a problem hiding this comment.
Why not just inspect.signature(value)?
|
Thanks for the suggestion to run tests under
|
closes #774.