Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only produce items_changed events on deleting list elements when items are actually removed #740

Merged
merged 5 commits into from
Jan 21, 2020

Conversation

k2bd
Copy link
Contributor

@k2bd k2bd commented Jan 13, 2020

Closes #738, unless there are additional ways of triggering this issue that I was not able to find.

TraitListObject.__delitem__ only emits an event if items are actually removed.

Kevin Duff added 3 commits January 13, 2020 20:04

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…s are actually removed
@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #740 into master will increase coverage by 0.25%.
The diff coverage is 72.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
+ Coverage    71.4%   71.66%   +0.25%     
==========================================
  Files          45       51       +6     
  Lines        6288     6355      +67     
  Branches     1282     1283       +1     
==========================================
+ Hits         4490     4554      +64     
- Misses       1395     1404       +9     
+ Partials      403      397       -6
Impacted Files Coverage Δ
traits/util/clean_strings.py 51.72% <ø> (ø) ⬆️
traits/testing/optional_dependencies.py 94.44% <ø> (ø) ⬆️
traits/adaptation/adaptation_manager.py 98.24% <ø> (ø) ⬆️
traits/etsconfig/etsconfig.py 63.8% <ø> (+0.22%) ⬆️
traits/__init__.py 71.42% <ø> (ø) ⬆️
traits/util/import_symbol.py 100% <ø> (ø) ⬆️
traits/adaptation/adapter.py 100% <ø> (ø) ⬆️
traits/testing/unittest_tools.py 96.03% <ø> (ø) ⬆️
traits/util/async_trait_wait.py 100% <ø> (ø) ⬆️
traits/adaptation/adaptation_offer.py 94.11% <ø> (ø) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e2a34...442a46e. Read the comment docs.

@k2bd k2bd changed the title Only produce items_changed events on deleting list elements when items are actually removed [WIP] Only produce items_changed events on deleting list elements when items are actually removed Jan 14, 2020
@k2bd k2bd changed the title [WIP] Only produce items_changed events on deleting list elements when items are actually removed Only produce items_changed events on deleting list elements when items are actually removed Jan 20, 2020
@k2bd
Copy link
Contributor Author

k2bd commented Jan 20, 2020

PR ready for review

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 811049d into master Jan 21, 2020
@mdickinson mdickinson deleted the 738-items-changed branch January 21, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

items_changed events should not be fired if no items have changed.
3 participants