-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Enum constants for trait kinds, validators and default values #680
Conversation
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
=========================================
Coverage ? 70.81%
=========================================
Files ? 45
Lines ? 6342
Branches ? 1291
=========================================
Hits ? 4491
Misses ? 1447
Partials ? 404
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; a couple of typos and a suggestion to document the NO_COMPARE
, ... constants.
I merged master (badly), fixed the bad merge, and also took the liberty of fixing one remaining use of NO_COMPARE
in a test.
Will fix merge conflicts shortly. |
Assigning to me for merge conflict resolution, minor updates, and merge. |
This is an attempt to remove as many magic numbers as possible from the traits source code, plus use new Python 3 features to do it.
Possibly should also add some C constants for validator types to ctraits.c.