Clean up test output #553
Clean up test output #553
Conversation
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=========================================
Coverage ? 65.39%
=========================================
Files ? 45
Lines ? 7059
Branches ? 1413
=========================================
Hits ? 4616
Misses ? 2021
Partials ? 422Continue to review full report at Codecov.
|
| @@ -258,7 +256,7 @@ def test_provisional_toolkit(self): | |||
|
|
|||
| with mock_sys_argv(test_args): | |||
| with mock_os_environ(test_environ): | |||
| print(repr(self.ETSConfig.toolkit)) | |||
| repr(self.ETSConfig.toolkit) | |||
There was a problem hiding this comment.
why remove the print but keep the call to repr?
There was a problem hiding this comment.
To keep the effect of the test. It's (indirectly) testing that the repr doesn't fail, so I wanted to keep that test.
| @@ -392,7 +393,7 @@ class Foo(HasTraits): | |||
| class Bar(HasTraits): | |||
| foo = Instance(IFoo) | |||
|
|
|||
| b = Bar(foo=Foo()) | |||
| Bar(foo=Foo()) | |||
There was a problem hiding this comment.
im guessing this too is a test where we simply instantiate the object and expect to see/not see errors.
There was a problem hiding this comment.
Yes, this was a drive-by fix to eliminate a flake8 warning about an unused variable, without changing the semantics of the test.
| self.fail( | ||
| msg="base.pp should have thrown AttributeError " | ||
| "as Category subclassing is not supported." | ||
| ) | ||
| except AttributeError: | ||
| pass | ||
|
|
||
| basepp = BasePlusPlus() | ||
| BasePlusPlus() |
There was a problem hiding this comment.
im guessing that this too is a test where we instantiate the object and we expect to see/not-see errors.
Silence warnings and remove a
printin a test.