Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that all tests are unittest-compatible. #551

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

mdickinson
Copy link
Member

This PR is preparation for changing the continuous integration to use unittest instead of nose.

We had only a handful of nose-style tests (i.e., tests not based on TestCase); this PR changes those to use unit test, and makes some minor renames to avoid some not-tests being picked up by nosetests.

With these changes, I see exactly 569 tests on master, with both nosetests and unittest discover.

And yes, some of these tests are horrible and in need of more work. But not in this PR.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one minor comment.

@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a98541e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #551   +/-   ##
=========================================
  Coverage          ?   65.39%           
=========================================
  Files             ?       45           
  Lines             ?     7059           
  Branches          ?     1413           
=========================================
  Hits              ?     4616           
  Misses            ?     2021           
  Partials          ?      422

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98541e...32dd0c1. Read the comment docs.

@mdickinson mdickinson merged commit 6e440aa into master Nov 12, 2019
@mdickinson mdickinson deleted the fix/denosify-tests branch November 12, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants