Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace two occurrences of AdaptedTo with Supports. #532

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

mdickinson
Copy link
Member

Fix one odd-looking use of super that was using the AdaptedTo alias for Supports instead of using Supports directly.

While we're here, change one other use of AdaptedTo in a comment, so that we're consistently using Supports everywhere outside the support for the backwards compatibility alias.

@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #532 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   65.15%   65.29%   +0.14%     
==========================================
  Files          44       44              
  Lines        7040     7040              
  Branches     1413     1413              
==========================================
+ Hits         4587     4597      +10     
+ Misses       2030     2021       -9     
+ Partials      423      422       -1
Impacted Files Coverage Δ
traits/trait_types.py 63.39% <100%> (ø) ⬆️
traits/etsconfig/etsconfig.py 63.58% <0%> (+6.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94308a2...9f1df26. Read the comment docs.

@mdickinson
Copy link
Member Author

@rahulporuri Would you be available for a quick review?

@mdickinson mdickinson merged commit c602b70 into master Nov 7, 2019
@mdickinson mdickinson deleted the fix/replace-adapted-to-with-supports branch November 7, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants