Remove redefinition of NullHandler #518
Conversation
traits/__init__.py
Outdated
| @@ -12,19 +15,6 @@ | |||
| # Add a NullHandler so 'traits' loggers don't complain when they get used. | |||
| import logging | |||
|
|
|||
| logging.getLogger("traits").addHandler(logging.NullHandler()) | |||
There was a problem hiding this comment.
q : why use "traits" instead of __name__?
There was a problem hiding this comment.
More explicit; no need to think hard about whether __name__ might ever possibly have the value "__main__".
There was a problem hiding this comment.
Having said that, I don't feel strongly about the change, and the __name__ version has greater copy-and-paste value.
|
I've changed back to |
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
=========================================
Coverage ? 65.31%
=========================================
Files ? 44
Lines ? 7050
Branches ? 1415
=========================================
Hits ? 4605
Misses ? 2022
Partials ? 423
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
=========================================
Coverage ? 65.31%
=========================================
Files ? 44
Lines ? 7050
Branches ? 1415
=========================================
Hits ? 4605
Misses ? 2022
Partials ? 423
Continue to review full report at Codecov.
|
Some cleanups to the top-level
__init__.py:NullHandleris in the standard library since Python 2.7, and we don't support Python 2.6. Remove the redefinition and use the std. lib. version