Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click.option-s should have help text #514

Merged
merged 3 commits into from
Aug 22, 2019
Merged

Click.option-s should have help text #514

merged 3 commits into from
Aug 22, 2019

Conversation

ulziibay
Copy link
Contributor

What?

Add help text to click.option

Why?

Click.option should ideally have a help text defined to be useful.

@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8515bbc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #514   +/-   ##
=========================================
  Coverage          ?   65.27%           
=========================================
  Files             ?       44           
  Lines             ?     7056           
  Branches          ?     1415           
=========================================
  Hits              ?     4606           
  Misses            ?     2025           
  Partials          ?      425

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8515bbc...7d34e37. Read the comment docs.

@mdickinson
Copy link
Member

Thank you for this contribution! I took the liberty of reverting the import changes, to keep this PR focused on a single thing.

Merging as soon as the continuous integration completes.

@mdickinson
Copy link
Member

By the way, I was looking at this yesterday and considering removing the "environment" option altogether. Is it something that you've found useful to have available?

@mdickinson mdickinson merged commit 2d8d7f5 into enthought:master Aug 22, 2019
@corranwebster
Copy link
Contributor

Not for traits, but I have been using the --environment option for traitsui's etstool to create longer-lived environments that don't get removed when running the full test suite.

@ulziibay
Copy link
Contributor Author

ulziibay commented Aug 22, 2019

Thanks @mdickinson for the thumbs up.

Is it something that you've found useful to have available?

I am not sure. I think you need this option still to be able to pass to the edm calls!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants