Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure of str_rfind for Unicode inputs #472

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Conversation

mdickinson
Copy link
Member

Fixes #471

@mdickinson mdickinson changed the base branch from master to release/5.1.x April 18, 2019 08:57
@rahulporuri
Copy link
Contributor

LGTM.

@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release/5.1.x@bc89672). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##             release/5.1.x     #472   +/-   ##
================================================
  Coverage                 ?   65.28%           
================================================
  Files                    ?       44           
  Lines                    ?     7061           
  Branches                 ?     1412           
================================================
  Hits                     ?     4610           
  Misses                   ?     2025           
  Partials                 ?      426
Impacted Files Coverage Δ
traits/_py2to3.py 81.35% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc89672...bfa9741. Read the comment docs.

@mdickinson mdickinson merged commit 0a964e6 into release/5.1.x Apr 18, 2019
@mdickinson mdickinson deleted the fix/str-rfind branch April 18, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants