Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: remove EOF markers #448

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Feb 1, 2019

Remove unnecessary and inconsistently applied "EOF" comments at ends of files. (Note: some of these were already removed in #446.)

@codecov-io
Copy link

Codecov Report

Merging #448 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   64.71%   64.85%   +0.14%     
==========================================
  Files          44       44              
  Lines        7130     7130              
  Branches     1418     1418              
==========================================
+ Hits         4614     4624      +10     
+ Misses       2092     2083       -9     
+ Partials      424      423       -1
Impacted Files Coverage Δ
traits/util/import_symbol.py 100% <ø> (ø) ⬆️
traits/etsconfig/etsconfig.py 63.58% <ø> (+6.17%) ⬆️
traits/adaptation/adapter.py 100% <ø> (ø) ⬆️
traits/adaptation/adaptation_manager.py 98.29% <ø> (ø) ⬆️
traits/util/clean_strings.py 0% <ø> (ø) ⬆️
traits/util/resource.py 12.06% <ø> (ø) ⬆️
traits/adaptation/adaptation_error.py 100% <ø> (ø) ⬆️
traits/adaptation/adaptation_offer.py 94.23% <ø> (ø) ⬆️
traits/util/deprecated.py 100% <ø> (ø) ⬆️
traits/testing/nose_tools.py 27.27% <ø> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef5313d...dca0624. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #448 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   64.71%   64.85%   +0.14%     
==========================================
  Files          44       44              
  Lines        7130     7130              
  Branches     1418     1418              
==========================================
+ Hits         4614     4624      +10     
+ Misses       2092     2083       -9     
+ Partials      424      423       -1
Impacted Files Coverage Δ
traits/util/import_symbol.py 100% <ø> (ø) ⬆️
traits/etsconfig/etsconfig.py 63.58% <ø> (+6.17%) ⬆️
traits/adaptation/adapter.py 100% <ø> (ø) ⬆️
traits/adaptation/adaptation_manager.py 98.29% <ø> (ø) ⬆️
traits/util/clean_strings.py 0% <ø> (ø) ⬆️
traits/util/resource.py 12.06% <ø> (ø) ⬆️
traits/adaptation/adaptation_error.py 100% <ø> (ø) ⬆️
traits/adaptation/adaptation_offer.py 94.23% <ø> (ø) ⬆️
traits/util/deprecated.py 100% <ø> (ø) ⬆️
traits/testing/nose_tools.py 27.27% <ø> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef5313d...dca0624. Read the comment docs.

@rahulporuri
Copy link
Contributor

LGTM. I don't see any more EOF markers in files.

@mdickinson mdickinson merged commit 8723489 into master Feb 5, 2019
@mdickinson mdickinson deleted the cleanup/remove-eof-markers branch February 5, 2019 08:21
@rahulporuri rahulporuri added this to the After 5.0.0 release milestone Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants