Avoid sys.modules hackery that was causing a NumPy-related test to fail. #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
==========================================
+ Coverage 64.71% 64.85% +0.14%
==========================================
Files 44 44
Lines 7130 7130
Branches 1418 1418
==========================================
+ Hits 4614 4624 +10
+ Misses 2092 2083 -9
+ Partials 424 423 -1
Continue to review full report at Codecov.
|
|
Self-merging after another self-review; (assessing this as low-risk, since it only touches a test). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an awkward test that needed to, in order, (1) try importing numpy to see whether the test should run at all, then (2) import traits.traits_types in an environment where numpy wasn't already imported. We were doing that by clearing out numpy-related entries in sys.modules, and that went wrong in #441. This PR replaces that test by one which runs the necessary imports in a subprocess, uncontaminated by previous NumPy imports.
Fixes #441