Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis CI script. #179

Merged
merged 3 commits into from
May 6, 2014
Merged

Update Travis CI script. #179

merged 3 commits into from
May 6, 2014

Conversation

mdickinson
Copy link
Member

Experimental PR to update the Travis configuration:

I'm not sure how this will affect the UI tests; let's see what happens. :-)

Addresses #178.

@enbuilder
Copy link

Merged build triggered. Test FAILed.

@enbuilder
Copy link

Merged build started. Test FAILed.

@enbuilder
Copy link

Merged build finished. Test PASSed.

@enbuilder
Copy link

Test PASSed.
Refer to this link for build results: http://jenkins.enthought.com:8080/job/Traits_PR_builder/54/

@mdickinson
Copy link
Member Author

Travis results are looking better: all tests pass on 2.6 and 2.7, and we're seeing failures on 3.2, 3.3 and 3.4, but the test suite is now running to completion on all those versions. The failures look like a problem in nose: nose-devs/nose#780.

@mdickinson
Copy link
Member Author

The nose bug is addressed in version 1.3.3, released earlier today.

@mdickinson
Copy link
Member Author

BTW, I suspect that our efforts to run the UI tests aren't actually making any difference here: we're running 463 tests and skipping 4, regardless of the PyQt install.

@enbuilder
Copy link

Merged build triggered. Test FAILed.

@enbuilder
Copy link

Merged build started. Test FAILed.

@enbuilder
Copy link

Merged build finished. Test PASSed.

@enbuilder
Copy link

Test PASSed.
Refer to this link for build results: http://jenkins.enthought.com:8080/job/Traits_PR_builder/55/

@mdickinson
Copy link
Member Author

And indeed, removing the before_install script doesn't affect either the total number of tests run or the number of tests skipped.

@mdickinson
Copy link
Member Author

Okay, I think this is ready to merge. @itziakos: interested in reviewing?

@enbuilder
Copy link

Merged build triggered. Test FAILed.

@enbuilder
Copy link

Merged build started. Test FAILed.

@enbuilder
Copy link

Merged build finished. Test PASSed.

@enbuilder
Copy link

Test PASSed.
Refer to this link for build results: http://jenkins.enthought.com:8080/job/Traits_PR_builder/56/

@itziakos
Copy link
Member

itziakos commented May 6, 2014

👍

@mdickinson
Copy link
Member Author

@itziakos: Thanks for the nose fix! Looks like we now have passing test runs on Python 2.6 through Python 3.4. 👏

mdickinson added a commit that referenced this pull request May 6, 2014
@mdickinson mdickinson merged commit af5baf7 into master May 6, 2014
@mdickinson mdickinson deleted the update-travis-config branch May 6, 2014 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants