Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Date, Time and Datetime behaviour #1736

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Remove deprecated Date, Time and Datetime behaviour #1736

merged 2 commits into from
Apr 17, 2023

Conversation

mdickinson
Copy link
Member

This PR updates the Date, Time and Datetime trait types for previous deprecations:

  • the Date trait type will now no longer accept datetime instances unless allow_datetime=True is used
  • the Date, Time and Datetime trait types will now no longer accept a value of None unless allow_none=True is used

Checklist

  • Tests
  • Update API reference (docs/source/traits_api_reference) - no changes needed
  • Update User manual (docs/source/traits_user_manual)
  • Update type annotation hints in stub files - no changes needed

@mdickinson mdickinson merged commit 7eefaa2 into main Apr 17, 2023
@mdickinson mdickinson deleted the remove-deprecated-date-time-datetime-behaviour branch April 17, 2023 16:05
@corranwebster corranwebster mentioned this pull request May 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corranwebster corranwebster corranwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdickinson @corranwebster