Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI for compatibility with Ubuntu 22.04 #1727

Merged
merged 29 commits into from
Dec 9, 2022
Merged

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Dec 7, 2022

This PR gets CI back to a working state on the latest ubuntu:

  • Drop Python 3.6, which isn't supported by the setup-python action on Ubuntu 22.04
  • Always test with PySide6 instead of using a mixture of PySide2 and PySide6
  • Don't try to install PySide6 on Python 3.11 (not supported yet) or 32-bit Windows (not supported at all)
  • Rework the apt-get list to reflect what's needed for using Qt 6 on Ubuntu.
  • Replace use of the third-party GabrielBB/xvfb-action with xvfb-run.

@mdickinson mdickinson marked this pull request as draft December 7, 2022 12:56
@mdickinson
Copy link
Member Author

Hmm. Looks like there are a number of other errors associated with the upgrade to ubuntu-22.04, too.

@mdickinson
Copy link
Member Author

Manual run for test-from-pypi: https://github.com/enthought/traits/actions/runs/3650793259

@mdickinson mdickinson marked this pull request as ready for review December 9, 2022 10:39
@mdickinson mdickinson changed the title Drop Python 3.6 from CI Update CI for compatibility with Ubuntu 22.04 Dec 9, 2022
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The requirements for the passing tests will need to be updated.

@mdickinson
Copy link
Member Author

Required checks updated

@mdickinson mdickinson merged commit 71672a8 into main Dec 9, 2022
@mdickinson mdickinson deleted the ci/drop-python36 branch December 9, 2022 11:38
mdickinson added a commit that referenced this pull request Jul 10, 2023
This PR gets CI back to a working state on the latest ubuntu:

- Drop Python 3.6, which isn't supported by the `setup-python` action on
Ubuntu 22.04
- Always test with PySide6 instead of using a mixture of PySide2 and
PySide6
- Don't try to install PySide6 on Python 3.11 (not supported yet) or
32-bit Windows (not supported at all)
- Rework the apt-get list to reflect what's needed for using Qt 6 on
Ubuntu.
- Replace use of the third-party GabrielBB/xvfb-action with xvfb-run.
@mdickinson mdickinson mentioned this pull request Jul 10, 2023
mdickinson added a commit that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants