Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TraitPrefixList and TraitPrefixMap #1703

Merged

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Aug 10, 2022

This PR removes the TraitPrefixList and TraitPrefixMap subclasses of TraitHandler, along with supporting machinery. For simplicity in branch-wrangling, it builds on the branch for PR #1702.

Closes #676
Closes #1639 (if not already closed)

Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couldn't find any remaining uses/mentions/references to TraitPrefixMap or TraitPrefixList.

@mdickinson mdickinson merged commit 927e167 into main Aug 10, 2022
@mdickinson mdickinson deleted the cleanup-remove-trait-prefix-map-and-trait-prefix-list branch August 10, 2022 14:43
mdickinson added a commit that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nitpicky issue : Code in documentation refers to SVN No longer special-case TraitPrefixList
2 participants